[PATCH] D57321: Fix LexFloatLiteral Lexing

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/test/MC/AsmParser/floating-literals.s:60
+# CHECK-ERROR: Invalid sign in float literal
+.double 2.+1
 
----------------
efriedma wrote:
> efriedma wrote:
> > We should probably have testcases for 1E1, 1e1e1, and 1e-1, since those don't work correctly without this patch.
> In this context, 1E1 is different from 1e1...
> 
> Probably best to check all of these with lowercase and uppercase "E".
Err, just realized my comment "1E1 is different from 1e1" might be unclear.  They *should* be treated the same way, but LLVM without this patch treats them differently, so we should have test coverage.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57321/new/

https://reviews.llvm.org/D57321