[PATCH] D54802: [LLD][COFF] Generate import modules in PDB

[Alexandre Ganea via Phabricator via llvm-commits]

aganea marked 3 inline comments as done.
aganea added inline comments.


================
Comment at: lld/trunk/COFF/PDB.cpp:1111
+    SC.Characteristics = OS ? OS->Header.Characteristics : 0;
     // FIXME: When we start creating DBI for import libraries, use those here.
     SC.Imod = Modi;
----------------
rnk wrote:
> Is this relevant to this change?
Yes, I think we can remove that comment now, unless @zturner says otherwise.


================
Comment at: llvm/trunk/lib/DebugInfo/PDB/Native/ModuleDebugStream.cpp:40-50
+  if (Mod.getModuleStreamIndex() != llvm::pdb::kInvalidStreamIndex) {
+    if (Error E = reloadSerialize(Reader))
+      return E;
+  }
+  if (Reader.bytesRemaining() > 0)
+    return make_error<RawError>(raw_error_code::corrupt_file,
+                                "Unexpected bytes in module stream.");
----------------
rnk wrote:
> I don't see the change to add this method to the class in this patch. Was this change intended to be part of this review? It seems unnecessary for import files.
I indeed forgot an include file from the diff. But you're right, this is for supporting empty streams, I should maybe do that in another patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54802/new/

https://reviews.llvm.org/D54802