[PATCH] D58957: [AMDGPU] Add an experimental buffer fat pointer address space.

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

LGTM, whether you do the NoAlias between constant 32-bit and buffer address space here or separately. (Making NoAlias between constant 32-bit and the other existing address spaces should definitely be a different patch.)



================
Comment at: lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp:65
+  /* Private  */        {MayAlias, NoAlias , NoAlias , NoAlias , NoAlias , MayAlias, NoAlias ,        NoAlias},
+  /* Constant 32-bit */ {MayAlias, MayAlias, MayAlias, NoAlias , MayAlias, NoAlias , NoAlias ,        MayAlias},
+  /* Buffer Fat Ptr  */ {MayAlias, MayAlias, NoAlias , NoAlias , MayAlias, NoAlias , MayAlias,        MayAlias}
----------------
sheredom wrote:
> nhaehnle wrote:
> > It may be more pragmatic to have NoAlias with Constant 32-bit.
> > 
> > The intention and current practice is for Constant 32-bit to be used with descriptor tables, and those really shouldn't ever alias buffer fat pointers. 
> Should I then actually be changing all the Constant 32-bit aliasing rules to only alias with itself do you think?
I think that's a good idea, but it should be a separate patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58957/new/

https://reviews.llvm.org/D58957