[PATCH] D59312: AMDGPU: Fix a SIAnnotateControlFlow issue when there are multiple backedges.

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

Hmm, this is fragile -- I think your reasoning about domination is mostly sound, except when there's uniform control flow inside the loop itself, in which case I'm not sure. That said, it seems to me that the domination check is conservative, and your change shouldn't break anything that wasn't broken before, and a proper fix is potentially much more difficult.

Agree with Matt that using update_test_checks.py is a good idea, apart from that I think this can go in.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59312/new/

https://reviews.llvm.org/D59312