[PATCH] D57803: [X86][GlobalISEL] Support lowering aligned unordered atomics

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D57803#1388399 <https://reviews.llvm.org/D57803#1388399>, @igorb wrote:

> The change looks ok.
>  Could you please add mir test for InstructionSelector pass, similar to select-memop-scalar.mir.
> Thanks


Went ahead and landed this with the mir test as requested, but honestly, I think the mir test is much less useful and readable than a plain IR test.  The sheer amount of *duplication* in the MIR file was distressing.

What I'd really have preferred - for global ISEL specific tests - was a version which started with IR, but used -stop-after=instruction-selector.  I couldn't find a way to do that w/an auto updated test though.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57803/new/

https://reviews.llvm.org/D57803