[PATCH] D59417: [GVN] Add default debug location when constructing PHI nodes
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 15 08:53:12 PDT 2019
aprantl added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/SSAUpdater.cpp:283
Updater->ProtoName, &BB->front());
+ // Add debug location with Line 0 and function scope to the new PHI node
+ if (BB->getParent()->getSubprogram()) {
----------------
This comment describes what the next line is doing, which is pretty obvious :-)
Could you please change it to describe *why* we are doing that? Basically what you wrote in the review description above?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59417/new/
https://reviews.llvm.org/D59417
More information about the llvm-commits
mailing list