[PATCH] D59228: Fix typos in compiler-rt/lib/builtins/atomic.c

[Xing Xue via Phabricator via llvm-commits]

xingxue updated this revision to Diff 190827.
xingxue added a comment.

Address review comments:

- Added a case for 1 byte to macro LOCK_FREE_CASES.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59228/new/

https://reviews.llvm.org/D59228

Files:
  compiler-rt/lib/builtins/atomic.c


Index: compiler-rt/lib/builtins/atomic.c
===================================================================
--- compiler-rt/lib/builtins/atomic.c
+++ compiler-rt/lib/builtins/atomic.c
@@ -135,23 +135,32 @@
 #define LOCK_FREE_CASES() \
   do {\
   switch (size) {\
+    case 1:\
+      if (IS_LOCK_FREE_1) {\
+        LOCK_FREE_ACTION(uint8_t);\
+      }\
+      break; \
     case 2:\
       if (IS_LOCK_FREE_2) {\
         LOCK_FREE_ACTION(uint16_t);\
       }\
+      break; \
     case 4:\
       if (IS_LOCK_FREE_4) {\
         LOCK_FREE_ACTION(uint32_t);\
       }\
+      break; \
     case 8:\
       if (IS_LOCK_FREE_8) {\
         LOCK_FREE_ACTION(uint64_t);\
       }\
+      break; \
     case 16:\
       if (IS_LOCK_FREE_16) {\
         /* FIXME: __uint128_t isn't available on 32 bit platforms.
         LOCK_FREE_ACTION(__uint128_t);*/\
       }\
+      break; \
   }\
   } while (0)
 
@@ -174,7 +183,7 @@
 /// pointer only.
 void __atomic_store_c(int size, void *dest, void *src, int model) {
 #define LOCK_FREE_ACTION(type) \
-    __c11_atomic_store((_Atomic(type)*)dest, *(type*)dest, model);\
+    __c11_atomic_store((_Atomic(type)*)dest, *(type*)src, model);\
     return;
   LOCK_FREE_CASES();
 #undef LOCK_FREE_ACTION


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59228.190827.patch
Type: text/x-patch
Size: 1241 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190315/097bb2cc/attachment.bin>