[PATCH] D58915: [AArch64] Refactor floating point materialization. NFC
Adhemerval Zanella via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 15 06:07:27 PDT 2019
zatrazz marked an inline comment as done.
zatrazz added inline comments.
================
Comment at: lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp:124
+ for (auto &I : Insn) {
+ bool LastItem = false;
+ switch (I.Opcode)
----------------
efriedma wrote:
> Is LastItem supposed to be set somewhere? Why isn't it used for AArch64::ORRXri?
It should be set for last item iteration, I will fix it. And my understanding why it is not set fo AArch64::ORRXri is the register used is always WZR/XZR.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58915/new/
https://reviews.llvm.org/D58915
More information about the llvm-commits
mailing list