[PATCH] D59372: [yaml2obj]Allow explicit setting of p_filesz, p_memsz, and p_offset

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/tools/yaml2obj/program-header-size-offset.yaml:53
+  # Program header with no sections.
+  - Type:     0x6abcdef0 # arbitrary type
+    Offset:   0x1234
----------------
jhenderson wrote:
> grimar wrote:
> > So out of curiosity: was it important for some reason to have an arbitrary numeric type here?
> > (and not a some kind of regular header)
> This was requested in an internal review of this before I put up a similar patch up for review previously. The idea is that the standard PT_* types have special semantics, and therefore by using a non-standard type, it bypasses any issues to do with it (and hopefully doesn't suggest that the type is important, together with the comment).
I see, thanks.

(to clarify: the first thing I tried when saw this is to lookup in LLVM for `6abcdef0` and `0xabcdef0`,
I did not instantly realize that it is just a set of alphabetical characters in order, but now after your reply
I re-read this place and that's looking fine for me now).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59372/new/

https://reviews.llvm.org/D59372