[PATCH] D59372: [yaml2obj]Allow explicit setting of p_filesz, p_memsz, and p_offset

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 15 03:26:22 PDT 2019


grimar added a comment.

I have a minor question. I do not think it is really important so should not be stoppable for landing this.



================
Comment at: test/tools/yaml2obj/program-header-size-offset.yaml:53
+  # Program header with no sections.
+  - Type:     0x6abcdef0 # arbitrary type
+    Offset:   0x1234
----------------
So out of curiosity: was it important for some reason to have an arbitrary numeric type here?
(and not a some kind of regular header)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59372/new/

https://reviews.llvm.org/D59372





More information about the llvm-commits mailing list