[PATCH] D59396: [MsgPack] Attempt to fix failure on windows expensive checks bot

[Tim Renouf via Phabricator via llvm-commits]

tpr updated this revision to Diff 190794.
tpr added a comment.
Herald added subscribers: nhaehnle, jvesely, arsenm.

V2: Also fix the same bug in Matt's AMDGPU MIR roundtrip commit.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59396/new/

https://reviews.llvm.org/D59396

Files:
  lib/BinaryFormat/MsgPackDocumentYAML.cpp
  lib/Target/AMDGPU/SIMachineFunctionInfo.cpp


Index: lib/Target/AMDGPU/SIMachineFunctionInfo.cpp
===================================================================
--- lib/Target/AMDGPU/SIMachineFunctionInfo.cpp
+++ lib/Target/AMDGPU/SIMachineFunctionInfo.cpp
@@ -325,6 +325,7 @@
   yaml::StringValue Dest;
   raw_string_ostream OS(Dest.Value);
   OS << printReg(Reg, &TRI);
+  OS.flush();
   return Dest;
 }
 
Index: lib/BinaryFormat/MsgPackDocumentYAML.cpp
===================================================================
--- lib/BinaryFormat/MsgPackDocumentYAML.cpp
+++ lib/BinaryFormat/MsgPackDocumentYAML.cpp
@@ -61,7 +61,7 @@
     llvm_unreachable("not scalar");
     break;
   }
-  return S;
+  return OS.str();
 }
 
 /// Convert the StringRef and use it to set this DocNode (assuming scalar). If


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59396.190794.patch
Type: text/x-patch
Size: 762 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190315/cf330a69/attachment-0001.bin>