[PATCH] D56828: [ELF] Simplify RelRo, TLS, NOBITS section ranks and make RW PT_LOAD start with RelRo

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

In D56828#1428674 <https://reviews.llvm.org/D56828#1428674>, @MaskRay wrote:

> > Looks good, please go ahead and modify the tests.
>
> I'll take that as approval as in offline discussion ruiu said he didn't have objection and was waiting on your decision :)


I intended to review your test changes first. I have now done so.



================
Comment at: lld/trunk/test/ELF/arm-plt-reloc.s:53
 // DSO-NEXT:     1020:       04 e0 2d e5     str     lr, [sp, #-4]!
 // (0x1024 + 8) + (0 RoR 12) + (0 RoR 20) + (0xfdc) = 0x2008 = .got.plt[3]
 // DSO-NEXT:     1024:       00 e6 8f e2     add     lr, pc, #0, #12
----------------
Same here.


================
Comment at: lld/trunk/test/ELF/arm-thumb-plt-reloc.s:63
 // DSOARM-NEXT:     1020:       04 e0 2d e5     str     lr, [sp, #-4]!
 // (0x1024 + 8) + (0 RoR 12) + (0 RoR 20) + (0xfdc) = 0x2008 = .got.plt[3]
 // DSOARM-NEXT:     1024:       00 e6 8f e2     add     lr, pc, #0, #12
----------------
The calculations in this file need to be updated.


================
Comment at: lld/trunk/test/ELF/pack-dyn-relocs-loop.s:12
 
 // This test is very sensitive to the exact section sizes and offsets,
 // so check that they don't change.
----------------
Can you check that this test fails if you revert the change that added the test?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56828/new/

https://reviews.llvm.org/D56828