[PATCH] D58892: [ELF] Split RW PT_LOAD on the PT_GNU_RELRO boundary

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 14 18:33:49 PDT 2019


pcc added a comment.

Is there a test that shows that the behavior is correct if a `.bss.rel.ro` is large enough to require another page?



================
Comment at: lld/trunk/test/ELF/pack-dyn-relocs-loop.s:12
 
 // This test is very sensitive to the exact section sizes and offsets,
 // so check that they don't change.
----------------
I think you need to change the size of `x` here so that this test continues to test what it is intended to test.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58892/new/

https://reviews.llvm.org/D58892





More information about the llvm-commits mailing list