[PATCH] D59039: [DAGCombine] Allow GatherAllAliases to pass through inline asm calls and glued nodes.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:19445
+      }
+      // If this had a glued output, return C so recursive calls of this
+      // succeed.
----------------
"If this had a glued output, return C"?

I don't follow why it matters if the output is glued, given there isn't a glue input.  If I'm understanding correctly, if the copy isn't glued, in it doesn't modify memory.  If the copy is glued, the only way to reach this case should be through a recursive call of ImproveChain.  Or are you just trying to be conservative here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59039/new/

https://reviews.llvm.org/D59039