[PATCH] D58892: [ELF] Split RW PT_LOAD on the PT_GNU_RELRO boundary

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 14 18:08:39 PDT 2019


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM. Splitting a PT_LOAD into two should be harmless for this case.



================
Comment at: ELF/Writer.cpp:1990
+        Sec == RelroEnd) {
 
       Load = AddHdr(PT_LOAD, NewFlags);
----------------
Remove the blank line.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58892/new/

https://reviews.llvm.org/D58892





More information about the llvm-commits mailing list