[PATCH] D59312: AMDGPU: Fix a SIAnnotateControlFlow issue when there are multiple backedges.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIAnnotateControlFlow.cpp:274
+    // track of the number of threads exited the loop at BB.
+    else if (L->contains(Pred) && DT->dominates(Pred, BB))
+      PHIValue = Broken;
----------------
Could this still break for some block that is in the loop, but doesn't dominate BB?


================
Comment at: test/CodeGen/AMDGPU/si-annotatecfg-multiple-backedges.ll:2
+; RUN: opt -mtriple=amdgcn-- -S -structurizecfg -si-annotate-control-flow %s | FileCheck -check-prefix=OPT %s
+
+
----------------
I kind of think we should just start generating the checks for any test that deals with control flow


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59312/new/

https://reviews.llvm.org/D59312