[PATCH] D49837: [SelectionDAG] Handle unary SelectPatternFlavor for ABS case in SelectionDAGBuilder::visitSelect.
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 14 16:24:41 PDT 2019
efriedma added inline comments.
================
Comment at: llvm/test/CodeGen/AArch64/iabs.ll:46
+; CHECK-NEXT: abs d0, d0
+; CHECK-NEXT: fmov x0, d0
; CHECK-NEXT: ret
----------------
RKSimon wrote:
> @efriedma IIRC we hit this before?
Yes; we intentionally marked "abs" as Expand for i64 to avoid this sort of sequence, since it's much higher latency. Not sure why this patch is reversing that decision.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D49837/new/
https://reviews.llvm.org/D49837
More information about the llvm-commits
mailing list