[PATCH] D59281: [WebAssembly] "atomics" feature implies shared memory

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 14 16:15:42 PDT 2019


tlively added a comment.

In D59281#1430026 <https://reviews.llvm.org/D59281#1430026>, @jfb wrote:

> D) Application uses (non-existent in WebAssembly) signal handling support and atomics just enforce program order.
>  E) Application is single-threaded but does cooperative interleaving of functions (but doesn't call it threads).


Thanks, JF! I definitely want to consider all cases. The cases you mention use atomics independently from threads, so I think they are further evidence that when the user uses -matomics we should never be stripping away their atomic operations and that it is dangerous to allow linking together objects with atomics both stripped and not stripped.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59281/new/

https://reviews.llvm.org/D59281





More information about the llvm-commits mailing list