[PATCH] D58848: [DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces"

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 14 15:39:42 PDT 2019


dblaikie added a comment.

In D58848#1430071 <https://reviews.llvm.org/D58848#1430071>, @avl wrote:

> I moved handling Undef case from Symbolizer into SymbolizableObjectFile. Please check whether it is proper place.


I'm still a little confused by the existence of a section search at all whet Undef is given - given that the previous implementation (before your work) there was no such search.

Is it possible the search could be omitted entirely?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58848/new/

https://reviews.llvm.org/D58848





More information about the llvm-commits mailing list