[PATCH] D59035: [X86] Promote i8 CMOV's (PR40965)

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:20552
+  // FIXME: we should not limit promotion of i8 case to only when the CMOV is
+  //        legal, but EmitLoweredSelect() can not deail with these extensions
+  //        being inserted between two CMOV's. (in i16 case too TBN)
----------------
"deail" -> deal


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:20557
+       Op.getValueType() == MVT::i16) &&
+      !MayFoldLoad(Op1) && !MayFoldLoad(Op2)) {
     Op1 = DAG.getNode(ISD::ANY_EXTEND, DL, MVT::i32, Op1);
----------------
The MayFoldLoad restriction really only applies to i16.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59035/new/

https://reviews.llvm.org/D59035