[PATCH] D59352: [WebAssembly] Make rethrow take an except_ref type argument

[Derek Schuff via Phabricator via llvm-commits]

dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.

otherwise LGTM



================
Comment at: lib/CodeGen/WasmEHPrepare.cpp:180
   // Insert an unreachable instruction after a call to @llvm.wasm.throw /
   // @llvm.wasm.rethrow and delete all following instructions within the BB, and
   // delete all the dead children of the BB as well.
----------------
Update the comment too.


================
Comment at: test/CodeGen/WebAssembly/cfg-stackify-eh.ll:36
 ; CHECK:   end_block                                   # label3:
-; CHECK:   call      __cxa_rethrow
+; CHECK:   rethrow   ${{.}}                            # to caller
 ; CHECK: end_try                                       # label0:
----------------
Here you are trying to match the `$` but below you are not. I guess the reason you are not checking the value (in catch or rethrow) is because these tests are only intended to verify the control flow?


================
Comment at: test/CodeGen/WebAssembly/wasmehprepare.ll:399
-; CHECK-LABEL: @test6
-define i32 @test6(i1 %b, i8* %p) {
-entry:
----------------
You've removed this test; should we also remove the code that it's testing?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59352/new/

https://reviews.llvm.org/D59352