[PATCH] D59386: [ValueTracking] ConstantRange based overflow detection for unsigned add/sub
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 14 14:27:22 PDT 2019
lebedev.ri added a comment.
> - The KnownBits are converted into ConstantRanges and the unsigned(Add|Sub)MayOverflow method on ConstantRange is used to determine the overflow condition. This part is NFC because this effectively matches what the code already did in a more explicit way.
Can you please at least separate the NFC ^ part?
> - Additionally call computeConstantRange() and intersect it with the KnownBits range.
> - Extend computeConstantRange() to compute constant ranges for constant integers and constant integer vectors.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59386/new/
https://reviews.llvm.org/D59386
More information about the llvm-commits
mailing list