[PATCH] D59343: [WebAssembly] Use passive segments when memory is shared

[Thomas Lively via Phabricator via llvm-commits]

tlively marked an inline comment as done.
tlively added inline comments.


================
Comment at: lld/test/wasm/data-segment-merging.ll:12
 ; RUN: llc -filetype=obj %s -o %t.data-segment-merging.o
+; RUN: llc -filetype=obj %s -o %t.data-segment-merging.atomics.o -mattr=+atomics
 
----------------
sbc100 wrote:
> The code looks like passive initiazlition is driver by the "--shared-memory" flag rather than atomics.   Wouldn't it make more sense to use "SHARED" over "ATOMICS" in this test?
D59284 makes the "atomics" feature imply the use of shared memory, and in this test the flag that causes shared memory to be used is `-mattr=+atomics`, so I think the current naming accurately describes what is happening. I expect the common way to get shared memory is by using the atomics feature, so perhaps we can even deprecate the --shared-memory flag, WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59343/new/

https://reviews.llvm.org/D59343