[PATCH] D58848: [DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces"

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/lib/DebugInfo/Symbolize/Symbolize.cpp:155-166
+  if (ModuleOffset.SectionIndex == object::SectionedAddress::UndefSection) {
+    std::pair<StringRef, StringRef> ParsedModuleName =
+        parseModuleName(ModuleName);
+
+    if (auto ObjectsOrErr = getOrCreateObjectPair(ParsedModuleName.first,
+                                                  ParsedModuleName.second))
+      ModuleOffset.SectionIndex = getModuleSectionIndexForAddress(
----------------
This code is repeated several times & again, still seems to be at the wrong layer of abstraction to me - having callers parse names, open files, search for sections - rather than passing in Undef and letting the underlying API do what it did before any of these changes.

I think it's further down that the Undef=>BestEffortSectionIndex should be handled - again, where it was effectively handled before any of these changes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58848/new/

https://reviews.llvm.org/D58848