[PATCH] D59261: [LLD][COFF] Separate module descriptors creation from type/symbol merging

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 14 13:01:25 PDT 2019


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: COFF/InputFiles.h:162
+  // Whether the object was already merged into the final PDB or not
+  bool Merged = false;
+
----------------
I would suggest `MergedIntoPDB` or something more descriptive. This is only used in one place, so it doesn't need to be short. "Merged" could mean a lot of things, and someone using DWARF might assume this was relating to PDBs.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59261/new/

https://reviews.llvm.org/D59261





More information about the llvm-commits mailing list