[PATCH] D59363: [SelectionDAG] Add icmp UNDEF handling to SelectionDAG::FoldSetCC

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 14 11:52:16 PDT 2019


efriedma added inline comments.


================
Comment at: test/CodeGen/ARM/ifcvt-branch-weight-bug.ll:1
 ; RUN: llc < %s -mtriple=armv4t--linux-androideabi -print-machineinstrs=if-converter -o /dev/null 2>&1 | FileCheck %s
 ; Fix a bug triggered in IfConverterTriangle when CvtBB has multiple
----------------
LGTM to commit separately.


================
Comment at: test/CodeGen/ARM/struct-byval-frame-index.ll:1
 ; RUN: llc < %s -mcpu=cortex-a15 -verify-machineinstrs -arm-atomic-cfg-tidy=0 | FileCheck %s
 
----------------
Also LGTM to commit separately.  (It's sort of hard to tell what this is aiming for, but I think you're fine as long as you preserve the CFG.)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59363/new/

https://reviews.llvm.org/D59363





More information about the llvm-commits mailing list