[PATCH] D59374: [InstCombine] canonicalize funnel shift constant shift amount to be modulo bitwidth

Thu Mar 14 11:41:03 PDT 2019

spatel marked an inline comment as done.
spatel added a comment.

In D59374#1429674 <https://reviews.llvm.org/D59374#1429674>, @nikic wrote:

> You might also want to kill this TODO: https://github.com/llvm-mirror/llvm/blob/master/lib/Analysis/InstructionSimplify.cpp#L4920
>
> Technically it's not quite solved because we're not guaranteed canonical IR, but it's probably not worth dealing with this in InstSimplify if we have this in InstCombine.

Agreed - there's almost no chance that other passes will run before instcombine and/or create non-canonical funnel shifts. Thanks for the quick reviews!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59374/new/

https://reviews.llvm.org/D59374