[PATCH] D59373: Make a hack for LTO work only when you are actually doing LTO.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 14 11:10:10 PDT 2019
ruiu marked an inline comment as done.
ruiu added inline comments.
================
Comment at: lld/ELF/Driver.cpp:220
+ if (identify_magic(P.first.getBuffer()) != file_magic::bitcode)
+ return;
+
----------------
efriedma wrote:
> "return"? It seems weird to intentionally ignore archive files without a symbol table.
But that is what other linkers do and is also a natural consequence of how linker works on archive files. When a linker visits an archive file, it reads its symbol table, and pulls out object files that defines symbols that are currently undefined. Therefore, if an archive doesn't contain a symbol table, nothing is pulled out, and the archive is effectively ignored.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59373/new/
https://reviews.llvm.org/D59373
More information about the llvm-commits
mailing list