[PATCH] D58599: [LLD] Add summary support

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Generally looking good, thank you for updating it.



================
Comment at: COFF/Driver.cpp:1002-1003
 
+  if (Args.hasArg(OPT_summary))
+    Config->ShowSummary = true;
+
----------------
nit: you could directly assign, like `Config->ShowSummary = Args.hasArg(OPT_summary)`.



================
Comment at: COFF/PDB.cpp:1374-1375
+  auto Print = [&](uint64_t V, StringRef S) {
+    if (!V)
+      return;
+    Stream << format_decimal(V, 15) << " " << S << '\n';
----------------
Printing out all values even if they are zero makes more sense to me, because having zero records is still a piece of information.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58599/new/

https://reviews.llvm.org/D58599