[PATCH] D59281: [WebAssembly] "atomics" feature implies shared memory

Thu Mar 14 08:59:23 PDT 2019

sbc100 added a comment.

In D59281#1429109 <https://reviews.llvm.org/D59281#1429109>, @sunfish wrote:

> In the future, atomics will likely be enabled by default, however it will continue to be desirable to be able to select non-shared memory, since non-shared memory doesn't require a maximum size, and since it can make interoperating with JS and other external code simpler. Is it possible to structure this patch in a way that supports this?

When building for non-shared memory, shouldn't input code check for "ifdef _REENTRANT" and not generate any atomic instructions?

The wasm spec says that atomics are simply not allowed when non-shared memory is used.  Do we need to hide this fact from the user code?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59281/new/

https://reviews.llvm.org/D59281