[PATCH] D59317: [ARM] Search backwards for CMP when combining into CBZ

[Dave Green via Phabricator via llvm-commits]

dmgreen marked 2 inline comments as done.
dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMConstantIslandPass.cpp:1931
+    if (Pred != ARMCC::AL || CmpMI->getOperand(1).getImm() != 0 ||
+        !isARMLowRegister(Reg))
+      continue;
----------------
samparker wrote:
> Do we need to still check this? I'm assuming we can't have a tCMPi8 with a high reg?
Yeah, good point. It's only the two register CMP that can take higher registers. I'll removed it here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59317/new/

https://reviews.llvm.org/D59317