[PATCH] D59120: [ELF] Sort notes by alignment in decreasing order

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 14 04:20:42 PDT 2019


peter.smith added a comment.

In D59120#1428640 <https://reviews.llvm.org/D59120#1428640>, @MaskRay wrote:

> Both choices look good to me:
>
> - emit one `PT_NOTE` for each `SHF_ALLOC` `.note*`
> - emit one `PT_NOTE` for adjacent `SHF_ALLOC` `.note*` with the same alignment (don't check alignment of their sizes)


I agree. I think either of those options will work.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59120/new/

https://reviews.llvm.org/D59120





More information about the llvm-commits mailing list