[PATCH] D59257: [ARM] Run ARMParallelDSP in the IRPasses phase

[Sam Parker via Phabricator via llvm-commits]

samparker marked an inline comment as done.
samparker added inline comments.


================
Comment at: lib/Target/ARM/ARMTargetMachine.cpp:411
+    addPass(createTypeBasedAAWrapperPass());
+    addPass(createScopedNoAliasAAWrapperPass());
+    addPass(createBasicAAWrapperPass());
----------------
SjoerdMeijer wrote:
> Under CodeGenOpt::Aggressive, I don't see adding a cleanup pass like CSE being a problem (e.g. for compile-times).
> However, I was wondering if we need all of these passes, like ScopedNoAliasAA.  I haven't looked at this pass before, so don't know what it is, do we need it? :-)
Scoped alias appears to handle the cases where code is inlined from functions. I know that I included this passes at some point for a good reason, but I cannot remember and the tests do not reflect their requirement... so I'll remove them for now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59257/new/

https://reviews.llvm.org/D59257