[PATCH] D59288: [DebugInfoMetadata] Move main subprogram DIFlag into DISPFlags

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro marked an inline comment as done.
djtodoro added a comment.

Thank you all for comments!

@aprantl

> Yes. Can you please add upgrade functionality into MetadataLoader and add a bitcode upgrade test into test/Bitcode?

Sure.



================
Comment at: include/llvm-c/DebugInfo.h:53
   LLVMDIFlagNoReturn = 1 << 20,
-  LLVMDIFlagMainSubprogram = 1 << 21,
-  LLVMDIFlagTypePassByValue = 1 << 22,
-  LLVMDIFlagTypePassByReference = 1 << 23,
-  LLVMDIFlagEnumClass = 1 << 24,
+  LLVMDIFlagTypePassByValue = 1 << 21,
+  LLVMDIFlagTypePassByReference = 1 << 22,
----------------
probinson wrote:
> Better to leave an unused bit in the middle? No need to reassign existing flags to new bits. The next time somebody adds a new flag, it can use the previously unused bit.  This will simplify the auto-upgrade as well.
It is better idea. We can do that way. Thanks!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59288/new/

https://reviews.llvm.org/D59288