[lld] r355894 - Fix test to unconditionally create a GNU-format archive.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 13 16:23:00 PDT 2019


lld uses LLVM's libObject to read archive files, and I believe the library
supports all variants of archive files, so it is odd that lld can't read
some archive variant. Something is not right...

On Mon, Mar 11, 2019 at 7:18 PM Eli Friedman via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: efriedma
> Date: Mon Mar 11 19:20:01 2019
> New Revision: 355894
>
> URL: http://llvm.org/viewvc/llvm-project?rev=355894&view=rev
> Log:
> Fix test to unconditionally create a GNU-format archive.
>
> On Darwin targets, llvm-ar creates a Darwin format archive by default,
> which ld.lld can't read, so it was printing an unexpected error.
>
>
> Modified:
>     lld/trunk/test/ELF/invalid/invalid-elf.test
>
> Modified: lld/trunk/test/ELF/invalid/invalid-elf.test
> URL:
> http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/invalid/invalid-elf.test?rev=355894&r1=355893&r2=355894&view=diff
>
> ==============================================================================
> --- lld/trunk/test/ELF/invalid/invalid-elf.test (original)
> +++ lld/trunk/test/ELF/invalid/invalid-elf.test Mon Mar 11 19:20:01 2019
> @@ -2,7 +2,7 @@
>  # RUN: rm -rf %t && mkdir -p %t
>  # RUN: llvm-mc %s -o %t/simple.o -filetype=obj -triple x86_64-pc-linux
>  # RUN: echo > %t/empty.o
> -# RUN: llvm-ar cr %t/not-elf.a %t/empty.o
> +# RUN: llvm-ar --format=gnu cr %t/not-elf.a %t/empty.o
>
>  # RUN: not ld.lld %t/simple.o %t/not-elf.a -o %t2 2>&1 | \
>  # RUN:   FileCheck --check-prefix=NOT-ELF %s
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190313/e2ab3ef1/attachment.html>


More information about the llvm-commits mailing list