[PATCH] D59311: [ELF] Dump symbols ordered by profiled guided section layout to file.

[Tiancong Wang via Phabricator via llvm-commits]

tcwang added a comment.

Thanks!



================
Comment at: lld/ELF/CallGraphSort.cpp:243
+        // and find out a Defined symbol with name that is within the section.
+        for (auto* Symbol: Sections[SecIndex]->File->getSymbols())
+          if (!Symbol->getName().empty())
----------------
ruiu wrote:
> We do not use `auto` unless its type is obvious from right-hand side.
> 
> `auto* Foo` -> `auto *Foo`
Ok. I will not use auto in this case. Thanks!


================
Comment at: lld/ELF/Driver.cpp:831
       Args.hasFlag(OPT_print_gc_sections, OPT_no_print_gc_sections, false);
+  Config->PrintSymbolOrderToFile =
+      Args.getLastArgValue(OPT_print_symbol_order);
----------------
ruiu wrote:
> Config members has the same name as their corresponding command line options, so please name it `PrintSymbolOrder`.
Ok. I'll change the name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59311/new/

https://reviews.llvm.org/D59311