[PATCH] D59322: [GlobalISel][AArch64] Gardening: Factor out vector inserts

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp:78
+                               MachineIRBuilder &MIRBuilder,
+                               MachineRegisterInfo &MRI) const;
   bool selectBuildVector(MachineInstr &I, MachineRegisterInfo &MRI) const;
----------------
We can find MRI from the MIRBuilder, so we can remove this parameter.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp:2334
 
   std::tie(Opc, SubregIdx) = getInsertVecEltOpInfo(RB, EltSize);
 
----------------
Can we pull this into emitLaneInsert()? Opc isn't used anywhere else and emit functions should ideally be able to figure this out themselves. The regbank and eltsize should also be derivable from the operand.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59322/new/

https://reviews.llvm.org/D59322