[PATCH] D58704: Initial (incomplete) implementation of JITLink - A replacement for RuntimeDyld.

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz added a comment.

I have no grounded knowledge about this, but I can say that it looks all much better than the the existing jitlink code. Hope it's gonna be compatible with ELF conceptually.



================
Comment at: lib/ExecutionEngine/JITLink/JITLinkGeneric.cpp:293-297
+    for (auto &KV : Layout) {
+    dbgs() << "  Segment "
+           << static_cast<sys::Memory::ProtectionFlags>(KV.first) << ":\n";
+    for (auto *DA : KV.second)
+      dbgs() << "    " << *DA << "\n";
----------------
lhames wrote:
> dblaikie wrote:
> > Indentation seems off here
> Hrm. Clang format is doing awful things to this. Will hand-format.
```
LLVM_DEBUG({
  ...
});
```
usually works well


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58704/new/

https://reviews.llvm.org/D58704