[PATCH] D59259: [AArch64] Use faddp to implement fadd reductions.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 13 13:48:32 PDT 2019


RKSimon added inline comments.


================
Comment at: include/llvm/Target/TargetSelectionDAG.td:284
+def SDT_FPVecReduce : SDTypeProfile<1, 1, [
+  SDTCisFP<0>, SDTCisVec<1>
+]>;
----------------
What happened to the accumulator argument? IMO we shouldn't have it all but the intrinsic currently defines it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59259/new/

https://reviews.llvm.org/D59259





More information about the llvm-commits mailing list