[PATCH] D58354: PowerPC: Add ImmArg to intrinsics

Wed Mar 13 12:48:42 PDT 2019

arsenm added a comment.

In D58354#1425849 <https://reviews.llvm.org/D58354#1425849>, @nemanjai wrote:

> Sorry about the delay. LGTM.
>
> I just have a question about the implications of setting these flags - is this only to produce better errors (i.e. when an intrinsic call with a non-immediate argument appears in IR)? Or are there other implications as well?
>  I am just looking to gauge the importance of going through all the intrinsics to see which other ones also require this property.

r356093.

No, this impacts transforms and codegen. In D58233 <https://reviews.llvm.org/D58233>, this will be required for correctness since then passes will be allowed to replace intrinsic call operands. If this isn't accurate, it will break. For GlobalISel, I also want this to change how intrinsics are emitted (D58232 <https://reviews.llvm.org/D58232>)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58354/new/

https://reviews.llvm.org/D58354