[PATCH] D59303: [DebugInfo] Pass all values in DebugLocEntry's constructor, NFC

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DebugLocEntry.h:127
     sortUniqueValues();
-    assert(all_of(Values, [](DebugLocEntry::Value V) {
-          return V.isFragment();
-        }) && "value must be a piece");
+    auto IsFragment = [](DebugLocEntry::Value V) { return V.isFragment(); };
+    assert(Values.size() == 1 || all_of(Values, IsFragment) &&
----------------
This'll get flagged as an unused variable (-Wunused) in a no-asserts build, so best to roll it back into the assertion.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59303/new/

https://reviews.llvm.org/D59303