[PATCH] D59237: [WebAssembly] Improve support for "needed" list in dylink section

[Sam Clegg via Phabricator via llvm-commits]

sbc100 marked an inline comment as done.
sbc100 added inline comments.


================
Comment at: llvm/lib/Object/WasmObjectFile.cpp:327
   // See https://github.com/WebAssembly/tool-conventions/blob/master/DynamicLinking.md
+  HasDylinkSection = true;
   DylinkInfo.MemorySize = readVaruint32(Ctx);
----------------
ruiu wrote:
> Is this dead code?
Its fixing a bug that isSharedLibrary(), which is only ever used by lld, was always returning false.

I guess at least some other tool such as objdump should probably be calling that and displaying different output for shared libs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59237/new/

https://reviews.llvm.org/D59237