[PATCH] D59227: [GlobalISel][Utils] Teach getConstantVRegVal how to look through trunc and z|sext
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 13 09:44:29 PDT 2019
arsenm added a comment.
In D59227#1426992 <https://reviews.llvm.org/D59227#1426992>, @qcolombet wrote:
> - Introduce a different variant of getConstantVRegVal instead of overriding the existing one (after talking to @aditya_nandakumar we decided we may want to have more control on what happens when we call this function).
> - Add a few comments.
>
> Longer term, I believe we don't want to legalize G_CONSTANT, but for this to happen we need to make sure we combine in the builder the extensions, otherwise we will have them hanging around and causing problem.
Why wouldn't G_CONSTANT be legalized? This doesn't make any sense to me
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59227/new/
https://reviews.llvm.org/D59227
More information about the llvm-commits
mailing list