[PATCH] D59260: [DAGCombiner] If a TokenFactor would be merged into its user, consider the user later.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 13 08:41:15 PDT 2019


courbet accepted this revision.
courbet added a comment.
This revision is now accepted and ready to land.

> X86/constant-combiners.ll -- Optimizes out overlap between stores.

I don't see that one.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1710
 
+  // If this is used only a single token factor, we should make sure we have a
+  // chance to merge them together. This prevents TF chains from inhibiting
----------------
"If the sole user of this node is a token factor, we should ..."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59260/new/

https://reviews.llvm.org/D59260





More information about the llvm-commits mailing list