[PATCH] D58858: [msan] Instrument x86 BMI intrinsics.

[Jonas Hahnfeld via Phabricator via llvm-commits]

Hahnfeld added a comment.

In D58858#1426718 <https://reviews.llvm.org/D58858#1426718>, @eugenis wrote:

> In D58858#1425740 <https://reviews.llvm.org/D58858#1425740>, @Hahnfeld wrote:
>
> > I'm running that configuration for years and it always worked. Do you have a change at hand that did such compiler change?
>
>
> Do you run msan lit tests? This is an example where new compiler behavior is tested the same change list, less than a year ago:
>  https://reviews.llvm.org/rL332761


Yes, I'm running `check-all` which includes the lit tests. However they are different in that they use the just-built clang executable which will include the fixes to the instrumentation passes. The unit tests are built with the host compiler (Clang 7 in my case) which obviously doesn't work.

Is there a reason the added test needs to be a unit test instead of a new lit test?


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58858/new/

https://reviews.llvm.org/D58858