[PATCH] D58919: WebAssembly: Irreducible control flow rewrite

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 12 17:24:38 PDT 2019


aheejin added a comment.

Real nit: We usually start CL/commit headers with `[WebAssembly]`



================
Comment at: lib/Target/WebAssembly/WebAssemblyFixIrreducibleControlFlow.cpp:64
 #include "llvm/CodeGen/MachineRegisterInfo.h"
 #include "llvm/CodeGen/Passes.h"
----------------
- Not sure what's happened, but it says "Context not available" on the diff on these lines. Could you rebase your CL onto the tip of the repo?
- We usually include `WebAssembly.h` in every pass, and I guess we need to include  (Maybe it's not shown here because of the diff problem?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58919/new/

https://reviews.llvm.org/D58919





More information about the llvm-commits mailing list