[PATCH] D59268: [Remarks] Add -foptimization-record-passes to filter remark emission

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg added a comment.

Thanks Jessica!



================
Comment at: llvm/lib/IR/RemarkStreamer.cpp:35-37
+  if (Optional<Regex> &Filter = PassFilter)
+    if (!Filter->match(Diag.getPassName()))
+      return;
----------------
paquette wrote:
> Maybe we should keep track of the number of passes we matched? If it's 0, then we can emit a warning saying that we didn't match anything.
> 
> I can imagine people misspelling pass names/writing bad regexes etc and maybe wanting this information.
> 
> I guess that could be done in a follow-up though.
That's a good idea, yes! I'll do that in a separate patch, thanks


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59268/new/

https://reviews.llvm.org/D59268