[PATCH] D59270: [WebAssembly] Handle undefined data symbols in shared libraries
    Rui Ueyama via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Mar 12 12:48:49 PDT 2019
    
    
  
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lld/wasm/Symbols.h:263
+  }
+  bool hasGlobalIndex() const {
+    return GlobalIndex != INVALID_INDEX;
----------------
nit: add a blank line between function definitions. (But if it fits in 80 cols, I believe the coding standard requires it to format in a single line like this:
  bool hasGlobalIndex() const { return GlolbalIndex != INVALID_INDEX; }
)
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59270/new/
https://reviews.llvm.org/D59270
    
    
More information about the llvm-commits
mailing list