[PATCH] D59262: [scudo][standalone] Add string utility functions

[Mitch Phillips via Phabricator via llvm-commits]

hctim marked an inline comment as done.
hctim added inline comments.


================
Comment at: lib/scudo/standalone/string_utils.cc:56
+
+s64 convertStringToS64(const char *NPtr, const char **EndPtr, int Base) {
+  CHECK_EQ(Base, 10);
----------------
cryptoad wrote:
> hctim wrote:
> > Personally, input params before output params, `EndPtr` should be after `Base`.
> This one was mostly to mirror the behavior & parameters of https://linux.die.net/man/3/strtol
> I am open to changing it if it makes sense to everyone.
Agreed, probably best to leave as-is then.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59262/new/

https://reviews.llvm.org/D59262