[PATCH] D59269: ELF: Use bump pointer allocator for uncompressed section buffers. NFCI.
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 12 12:24:49 PDT 2019
pcc added a comment.
In D59269#1426604 <https://reviews.llvm.org/D59269#1426604>, @ruiu wrote:
> I wonder how much does it actually cost to acquire a lock under the situation where there's no contention. Except this place, all accesses to BAlloc are already serialized, so there's usually no contention. If the cost of acquiring a lock under that situation is negligible, I'd imagine that always acquiring the lock could be a reasonable option.
The only other user of `BAlloc` is `StringSaver` (all other allocations use a `SpecificBumpPtrAllocator`). Are you proposing to change `BumpPtrAllocator::Allocate` to take a lock?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59269/new/
https://reviews.llvm.org/D59269
More information about the llvm-commits
mailing list